New theme extension Karlskrona #901
Replies: 1 comment 4 replies
-
|
Finally another developer who shares my bent for semantic elements. 👍 I see you have added a class attribute to the opening |
Beta Was this translation helpful? Give feedback.
-
|
Thank you very much Steffen! I think semantic elements make a lot of things easier. The edit extension works, but is not styled. Maybe I'll do that later. |
Beta Was this translation helpful? Give feedback.
-
|
Just gave it a try, and unfortunately your theme has the same small issue as mine. You can test it by visiting the edit location of your website while logged out. Then enter some wrong credencials to make Yellow display a "try again" link. This link won't work if your theme is loaded. From what i found out the edit extension expects the presence of a top-level div element with appropriate page layout classes after the opening body tag. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks a lot for testing! I'll take a look at it later and fix it. |
Beta Was this translation helpful? Give feedback.
-
|
I have removed the classes from the body tag and it still doesn't work. I then set up a fresh Yellow installation and tested the procedure there too, with the result that it doesn't work there either. It should call |
Beta Was this translation helpful? Give feedback.
-
Since almost every time I install Yellow for a new project I go through the code to delete the CSS classes and add semantic elements (header, main, footer, section, article, etc.) in preparation for using Pico, I thought I'd just create a theme to get the next project going faster.
I only implemented the pico.css in the theme. For my projects, I also use the sass files.
You can find the theme here: yellow-karlskrona
Beta Was this translation helpful? Give feedback.
All reactions