Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies and peer-dependencies are incorrect #213

Open
donaldboulton opened this issue Jan 20, 2023 · 3 comments
Open

Dependencies and peer-dependencies are incorrect #213

donaldboulton opened this issue Jan 20, 2023 · 3 comments
Labels

Comments

@donaldboulton
Copy link

donaldboulton commented Jan 20, 2023

The below Gatsby plugins should be in dependencies. as well as React and React Dom

"gatsby": "^4.24.0 || ^5.0.0", "gatsby-plugin-image": "^2.0.0 || ^3.0.0", "gatsby-plugin-sharp": "^4.0.0 || ^5.0.0", "gatsby-transformer-remark": "^5.0.0 || ^6.0.0",

preDependencies are totally wrong and point to older Gatsby plugin's.

"peerDependencies": { "gatsby": ">= 4.24.0", "gatsby-plugin-image": ">= 1.0.0", "react": "*", "react-helmet": ">= 5.0.0" },

should be

"peerDependencies": { "gatsby": ">= 5.0.0", "gatsby-plugin-image": ">= 3.0.0", "react": "*", "react-helmet": ">= 6.0.0" },

This is a temp fix. That will work with Gatsby 5

You get rid of react-helmet and datoHelmet and use the new API using Gatsby Head

@sistrall sistrall changed the title Dependency's & Per dependencies are incorrect Dependencies and peer-dependencies are incorrect Feb 9, 2023
@stefanoverna
Copy link
Member

Our package supports both Gatsby 4 and 5, so that's why we keep "gatsby": ">= 4.24.0" (similar reasoning for gatsby plugins).

I don't understand if having "gatsby": ">= 4.24.0" is a problem for you. Should be compatible with Gatsby 5, right?

@graeme120
Copy link

Our package supports both Gatsby 4 and 5, so that's why we keep "gatsby": ">= 4.24.0" (similar reasoning for gatsby plugins).

I don't understand if having "gatsby": ">= 4.24.0" is a problem for you. Should be compatible with Gatsby 5, right?

I'm having a similar problem. DatoCms is not appearing in Gatsby project's graphiql page. Has this been resolved or has a permanent solution been found?

@matjack1 matjack1 added the bug label Mar 20, 2023
@sistrall
Copy link
Contributor

Hi @graeme120,

I'll be happy to help, but I need more context: what's the problem? Which version of Gatsby are you using?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants