This repository has been archived by the owner on Sep 11, 2018. It is now read-only.
Fix webpack client config #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdzkwsk
pushed a commit
that referenced
this pull request
Aug 25, 2015
Fix webpack client config spacing
|
Oh awesome, thanks so much! I never even thought about that. Merged. |
|
Thanks! |
|
@davezuko Man, I just realized that it wasn't such a good fix... the https://github.com/davezuko/react-redux-starter-kit/blob/master/config/index.js#L1 Otherwise, (on windows AFAIK) you get this output: process.env.NODE_ENV // "production "
process.env.NODE_ENV === 'development' // false
process.env.NODE_ENV === 'production' // falseI'll send another PR to fix that, it's ok? |
|
Yeah sure. Is this just a Windows issue then? Because I've yet to have trouble on OSX/Ubuntu. |
|
Ok I'll send it! Yes, I suppose it's just a windows issue... -.- |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The require call was failing due to an extra space so, I just added a
.trim()... 😄This is my npm script that was raising the error (I'm on Windows right now):
"deploy": "SET NODE_ENV=production && npm run test && npm run compile"Thanks!