New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Normalization of git URLs (moduleInfo.repository) does not work as intended #30

Closed

mwittig opened this issue Jan 26, 2015 · 1 comment

mwittig commented Jan 26, 2015

Sorry, I am not able to create a fork & pull request at the moment.

The Normalization of git URLs (moduleInfo.repository) in index.js, line 40 and following does not work as intended.

40: moduleInfo.repository = json.repository.url.replace('git://github.com', 'https://github.com').replace('.git', '');
41: moduleInfo.repository = json.repository.url.replace('git@github.com:', 'https://github.com/').replace('.git', '');

The assignment in line 40 has no effect as it is overwritten by the assignment in line 41. Suggested Fix:

Change line 41 as follows:
moduleInfo.repository = moduleInfo.repository.replace('git@github.com:', 'https://github.com/').replace('.git', '');

davglass closed this as completed in

a3fefdb

Owner

davglass commented Jan 26, 2015

Published in license-checker@2.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment