Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested replacements in game export #66

Open
david-pfx opened this issue Jul 19, 2024 · 1 comment
Open

Suggested replacements in game export #66

david-pfx opened this issue Jul 19, 2024 · 1 comment
Labels
enhancement Improvement to existing capability

Comments

@david-pfx
Copy link
Owner

Karoo: here are some of the replacements i did in the export for my game, that i think other games might want options to do the same:

remove margins around game so its full screen (also hide title and footer):
top:3.5em;bottom:3em
top:0;bottom:0
title{
title{display:none;
footer{
footer{display:none;

make mute button semitransparent to match itch's fullscreen button, disable highlighting of mute button:
muteAudio() style=display:none
muteAudio() class="disable-select" style="display:none;opacity:0.4"
unMuteAudio() style=display:none
unMuteAudio() class="disable-select" style="display:none;opacity:0.4"

make esc go to level select directly:
else goToPauseScreen()
else gotoLevelSelectScreen()

remove the # fill when selecting a level, this looks really bad imo:
"#"+s.padEnd(24,"#")
" "+s.padEnd(24)

change the loading screen to say loading:
"Please select a game"
"Loading..."

remove new game option, only continue:
o.push(r&&!hasFinishedTheGame()?MENUITEM_CONTINUE:MENUITEM_NEWGAME),!state.metadata.level_select||state.metadata.continue_is_level_select&&r||o.push(MENUITEM_LEVELSELECT),r&&!hasFinishedTheGame()&&o.push(MENUITEM_NEWGAME)
o.push(MENUITEM_CONTINUE),!state.metadata.level_select||state.metadata.continue_is_level_select&&r||o.push(MENUITEM_LEVELSELECT)
[12:12]Karoo:
removing margins, title and footer should be an export option, some forks of ps do this by default
mute button transparency and unselectable should be given to everyone, i see this as better in every way
esc directly to level select could be a prelude flag, maybe no-pause-screen or something, but it has to be made to handle games with no level select correctly, so im not sure what the behavior should be in that case
removing # fill i think should be given to everyone, its very ugly with how theres a gap for the level completion mark. a lot more of that logic could be removed than my replacement
no opinion on the loading screen text
no new game option could be a prelude flag, but its not that important

@david-pfx
Copy link
Owner Author

1: I don't see any margins???
2: Yes, could be an export option, but there is no support for them.
3: menus need discussion.
4: remove fill -- I agree.
5: "Please select a game" should never be seen in an export. How did that happen?
6: menus need discussion.

@david-pfx david-pfx added the enhancement Improvement to existing capability label Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing capability
Projects
None yet
Development

No branches or pull requests

1 participant