Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional chaining support #424

Closed
wants to merge 4 commits into from

Conversation

subtlepath
Copy link

Adds "optional" parameter support to CallExpression and MemberExpression in line with latest ESTree

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #424 (b99ffde) into master (d820f9f) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #424      +/-   ##
==========================================
+ Coverage   95.48%   95.54%   +0.05%     
==========================================
  Files           1        1              
  Lines         554      561       +7     
==========================================
+ Hits          529      536       +7     
  Misses         25       25              
Impacted Files Coverage Δ
src/astring.js 95.54% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d04f8...b99ffde. Read the comment docs.

@davidbonnet
Copy link
Owner

Thanks @subtlepath for extending support. Squashed updated changes directly into master since I did not have push access to your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants