Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing parentheses in LogicalExpression #571

Closed
pablobfonseca opened this issue Sep 28, 2021 · 1 comment · Fixed by #590
Closed

Missing parentheses in LogicalExpression #571

pablobfonseca opened this issue Sep 28, 2021 · 1 comment · Fixed by #590
Labels
bug

Comments

@pablobfonseca
Copy link

Motivation

SyntaxError: Logical expressions and coalesce expressions cannot be mixed. Wrap either by parentheses (1:14)

Expected behavior

It should keep the parentheses.

Actual behavior

The following code:

(false || true) ?? !1

is being transformed without parentheses, and throwing a SyntaxError
@joedelia joedelia mentioned this issue Oct 1, 2021
Closed
@davidbonnet davidbonnet added the bug label Oct 6, 2021
@davidbonnet
Copy link
Owner

Thanks @pablobfonseca for reporting this, should be fixed shortly.

@davidbonnet davidbonnet mentioned this issue Nov 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: wrong precedence of nullish operator davidbonnet/astring
2 participants
@davidbonnet @pablobfonseca