Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

baseGenerator is untyped #604

Closed
wooorm opened this issue Jan 25, 2022 · 2 comments
Closed

baseGenerator is untyped #604

wooorm opened this issue Jan 25, 2022 · 2 comments
Labels
bug

Comments

@wooorm
Copy link

wooorm commented Jan 25, 2022 •
edited
Loading

it’s missing.
Even though it’s deprecated, it’s probably a good idea to type it, and add @deprecated to signal that to users.
@wooorm
Copy link
Author

wooorm commented Jan 25, 2022

Also: write is missing the 2nd parameter node: https://github.com/davidbonnet/astring/blob/main/astring.d.ts#L10.

@davidbonnet
Copy link
Owner

Thanks @wooorm for reporting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidbonnet @wooorm