Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keybindings Ctrl+e and Ctrl+r don't work under Windows + git bash or Windows + Ubuntu in WSL mode #23

Open
1kastner opened this issue Apr 27, 2021 · 10 comments

Comments

@1kastner
Copy link

Hi there, thanks for this great project!

I just tried it out. I created some cells and tried to run them. But somehow the key combinations Ctrl+e and Ctrl+r didn't get through so that I could never run the code cells. I guess this issue would be solved if I just created my custom key bindings and avoided the Ctrl key at all.

@davidbrochart
Copy link
Owner

Thanks @1kastner!
If ctrl-e and ctrl-r are problematic, then maybe we should change it. These are different from the Notebook, which uses ctrl-enter and shift-enter, but I don't think it's possible to have them in the terminal.
I'm open to suggestions.

@ogrisel
Copy link

ogrisel commented Apr 27, 2021

This does not seem to work on macOS (11) either (using the default Terminal.app).

@davidbrochart
Copy link
Owner

Thanks for reporting @ogrisel, what about changing them to just e and r (without ctrl)? I guess this will be less problematic.

@1kastner
Copy link
Author

For me that sounds totally fine!

@Jacke
Copy link

Jacke commented Apr 28, 2021

It's not working. Drop the CTRL button!!! I can't even quit from the notebook app, latest big sure fast mac laptop

@twolodzko
Copy link

On Ubuntu the key bindings do not work at all. The only thing I was able to do was to type text, but without tabs as they did not work. No way to run the cell etc. There is even no way to exit the app (I need to close the terminal). I tried it on two different Linux PC's. In both cases using the build-in gnome terminal app.

@davidbrochart
Copy link
Owner

I use Lubuntu, with LXTerminal. Maybe the key bindings interfere with GNOME Terminal?

@manics
Copy link

manics commented May 4, 2021

Interestingly Ctrl+e and Ctrl+r do work for me in WSL Ubuntu ¯\_(ツ)_/¯
Certain sequences of Ctrl+e/Ctrl+r/up-arrow/down-arrow seem to lead to 100% cpu usage, but I've no idea if that's related or some other bug- if I narrow it down I'll open a new issue.

@1kastner
Copy link
Author

1kastner commented May 4, 2021

I just replaced the key bindings and when I reduced it to e or r, everything was fine.

@dirkroorda
Copy link

It could be that the bindings work fine, but that cell execution does not work. See #41 , #24.
Also the problem of not quitting is caused by cells not running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants