When exporting to Webp, the ColorProfile is getting removed

[prashik-s]

If the input image already has an ICC Profile embedded into it, the ICC Profile is getting dropped when converting to Webp. This happens if we don't make a call to OptimizeICCProfile . The OptimizeICCProfile function updates the variable optimizedIccProfile.
While exporting a Webp, govips looks at the params for ICC Profile. If we don't send an ICC Profile in the export params and the optimizedIccProfile variable is not set, then the ICC Profile of the image is dropped.

Problematic code:

// ExportWebp exports the image as WEBP to a buffer.
func (r *ImageRef) ExportWebp(params *WebpExportParams) ([]byte, *ImageMetadata, error) {
	if params == nil {
		params = NewWebpExportParams()
	}

	paramsWithIccProfile := *params
	paramsWithIccProfile.IccProfile = r.optimizedIccProfile

	buf, err := vipsSaveWebPToBuffer(r.image, paramsWithIccProfile)
	if err != nil {
		return nil, nil, err
	}

	return buf, r.newMetadata(ImageTypeWEBP), nil
}

There should be a check here if the image has it's own ICC profile and it shouldn't be dropped.

[dmytro-brykovets-quarks-tech]

Just had to fix it with OptimizeICCProfile as well. Also, this code ignores if params.IccProfile is set by the user.

[tonimelisma]

Thanks. Anyone have energy to create a PR? I'd be happy to merge one.

[prashik-s]

closes #410

[prashik-s]

@tonimelisma Can you review?

[tonimelisma]

Merged

[davidlazar]

I'm confused: it seems the PR was merged and then reverted. I'm still having this issue.