Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] liquid-c not found #118

Closed
MJochim opened this issue Feb 25, 2019 · 5 comments
Closed

[Bug] liquid-c not found #118

MJochim opened this issue Feb 25, 2019 · 5 comments
Assignees

Comments

@MJochim
Copy link

MJochim commented Feb 25, 2019

Please read the contributing guidelines and code of conduct before creating an issue.

As an aside: The links above are broken. Those that appear to the right while writing this issue (“it looks like this is your first time opening an issue in this project …” work fine.

After the upgrade to 3.0.7, I cannot build my Alembic-themed jekyll sites anymore. I tried on an Arch Linux machine (ruby 2.5.3p105) and within an Alpine-based docker container (don't know the Ruby version there). I always get this error:

  Dependency Error: Yikes! It looks like you don't have liquid-c or one of its dependencies installed. In order to use Jekyll as currently configured, you'll need to install this gem. The full error message from Ruby is: 'cannot load such file -- liquid-c' If you run into trouble, you can find helpful resources at https://jekyllrb.com/help/! 

I can reproduce this using the following minimal example with only two files:

Gemfile:

source "https://rubygems.org"
gem "jekyll"
gem "alembic-jekyll-theme"

_config.yml

theme: alembic-jekyll-theme

bundle install && bundle exec jekyll serve results in the above error. Adding gem "liquid-c" to Gemfile does not help. I am not a Ruby guy, I may have missed something I need to do. But to me, this looks like a bug in the theme. It would be great if you could take a look!

@daviddarnes
Copy link
Owner

Hey @MJochim, sorry you're having trouble with the new version of Alembic. Seems odd that it's not installing liquid-c, the reference for the gem is right here https://github.com/daviddarnes/alembic/blob/master/alembic-jekyll-theme.gemspec#L29. I'll have a go installing a fresh to see if I get the error. Have you tried installing outside the docker container as a plain Jekyll project? Also, what version of Jekyll are you using?

@MJochim
Copy link
Author

MJochim commented Feb 25, 2019

Yes, the Arch Linux machine is non-docker. I'm using Jekyll 3.8.5:

$ bundle exec jekyll --version
jekyll 3.8.5
$ jekyll --version
jekyll 3.8.5
$ ruby --version
ruby 2.5.3p105 (2018-10-18 revision 65156) [x86_64-linux]

Just now I deleted liquid-c manually ($GEM_HOME/gems/liquid-c-4.0.0 and $GEM_HOME/specifications/liquid-c-4.0.0.gemspec) and then re-executed bundle install && bundle exec jekyll serve. The result is:

[…]
Using jekyll-sitemap 0.13.0
Using gemoji 3.0.0
Using jemoji 0.10.2
Fetching liquid-c 4.0.0
Installing liquid-c 4.0.0 with native extensions
Using alembic-jekyll-theme 3.0.7
Using bundler 1.17.1
Bundle complete! 2 Gemfile dependencies, 48 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.

So it does re-install liquid-c (and I can confirm that by looking at $GEM_HOME/gems/liquid-c).

But the error message from bundle exec jekyll serve remains.

@osheroff
Copy link

having the same problem. downgrading to 3.0.6 fixes.

@daviddarnes
Copy link
Owner

Well it's nice to know people are keeping up to date and using the theme, but sad I've broken your stuff :(. I've released 3.0.8 which removes liquid-c entirely, could you report back if it's working? Thanks all!

@MJochim
Copy link
Author

MJochim commented Feb 26, 2019

Well, thank you for your exceptionally fast response - and for the theme in the first place :-).

Upgrading to 3.0.8 works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants