Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internals: Avoid deletion of unused snapshots when running tests if {doconv} is not installed #618

Open
markheckmann opened this issue Oct 2, 2024 · 1 comment

Comments

@markheckmann
Copy link
Contributor

markheckmann commented Oct 2, 2024

Currently, if {doconv} or MS Office / LibreOffice is not installed on the system when running the tests, {testthat} will remove unused snapshots. As discussed here, this appears to be normal {testhat} behavior (also a workaround is supplied). It's nothing critical but could be fixed just for convenience.

deleting-unused-snapshots

@davidgohel
Copy link
Owner

I'd like to totally get rid of these visual tests or reduce them to a resulting minimum set of snapshots. Since officer is quite stable now, I think it's possible. I hope I'll have time for it soon.

'doconv' is useful but not very reliable because Office 365 check the license and maybe other operations that make it quite slow. Also it can't work in Github Actions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants