Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not pollute with global variables #324

Closed
itchyny opened this issue Nov 18, 2014 · 2 comments
Closed

Do not pollute with global variables #324

itchyny opened this issue Nov 18, 2014 · 2 comments

Comments

@itchyny
Copy link
Contributor

itchyny commented Nov 18, 2014

I found three global variables you might not intend them to be. The variables e, l1, l2 at https://github.com/davidhalter/jedi-vim/blob/master/after/syntax/python.vim#L4 are global variables. When we open a python file and you confirm the leak with :echo [e, l1, l2]. Make them script local or put them into a function.

@davidhalter
Copy link
Owner

Yes, we should fix that. What's the best fix? s:? If you want you can do a PR.

@itchyny
Copy link
Contributor Author

itchyny commented Nov 18, 2014

Yup, add s: to all the occurrence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants