Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Add option for manual offset #1030

Closed
JasonTheAdams opened this issue Jan 13, 2022 · 2 comments
Closed

FR: Add option for manual offset #1030

JasonTheAdams opened this issue Jan 13, 2022 · 2 comments

Comments

@JasonTheAdams
Copy link

Describe the bug
We have an iframe with a box shadow. When the iframe resizes the box shadow is clipped as it's not calculated in the container height.

To Reproduce
Steps to reproduce the behavior:

  1. Create an iframe with a box shadow
  2. Resize the iframe to a new height
  3. Look at the bottom of the iframe and notice the box shadow is clipped

Expected behavior
If there was an offsetHeight option, we could simply set a value which compensates for the box shadow. The offset would simply be applied to the final calculated height and would be a constant. It wouldn't be necessary for us, but allowing for a callback could also be helpful for someone to calculate the offset at each moment of resize.

Screenshots
image

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Brave
  • Version 1.34.80
@davidjbradshaw
Copy link
Owner

Happy to take a PR for this, can you please add width as well

@davidjbradshaw
Copy link
Owner

Fixed in V5.0.0 #1205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants