-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
downsize seemingly not working on chromium? #1355
Comments
Hi, This will turn out to be a CSS issue. iframe-resizer manages to work around most of these, but have a look at this page that details a few ways CSS can trip things up and how to work around them. https://iframe-resizer.com/content_guidelines/ I’m interested to know how this only affects Chrome, so will take a more detailed look later in the week. It would be very helpful if you could install the latest beta version and turn logging on to enable me to see what is happening. npm i @iframe-resizer/child@beta |
Looking at those logs, it appears that you’re loading a new page into the iframe. As part of the page setup iframe-resizer sets the height of both the The interesting bit, is that after the initial size calculation is done, it appears not to be happy with this and checks it another two times, but your page CSS is still reporting that the So my question is how is that height value on |
Yes, I do load a new page into the iframe whenever the selection in the select changes. Unfortunately, the webapp within the iframe is based on a rather old framework, the pages are server-side generated whenever an action occurs in the browser. Not a modern single-page client side js app. Regarding your question, I'll try to find out, but I need the help of a colleague. |
Hi David, Instead of using the height of the body-element, we saw that the script adds a empty div ( We found this solution: |
That behaviour is going to be caused by something in your CSS, the solution will be to remove the CSS that causes the issue, rather than adding more CSS to try to overpower the root cause. If you want to use a a particular element on the page for sizing the iframe, you can add a |
I fully agree that we should find the root cause. We tried on a test page w/out any css or js (apart from iframe-resizer), but still doesnt downsize in chrome. https://tp.dav-usc-muenchen.de/iframe.html Could you maybe point us to an example page where downsizing works? That could be helpful in finding our root cause... thx! |
That’s very strange, have you tried the /example/html folder in this git project? The different examples are all separate html pages that you can navigate between in Chrome and each one will cause the iframe to change size, as it loads. |
Have you tried another copy/version of Chrome? Just wondering if the issue is a browser plugin? |
Sorry for the slow reply, I've been unwell. Do you still have the broken example online? |
Hi Dave, yes it's still online: with inside body (working as a charm): https://www.dav-usc-muenchen.de/kurse-touren-veranstaltungen/kalender without div (downsize not working): Thanks for your effort! |
Describe the bug
resizing iframe (up- and downsizing) works perfectly on firefox, but seemingly not in chromium browsers
To Reproduce
Steps to reproduce the behavior:
5.b iframe downsized accordingly (if using firefox, see scons screenshot)
Expected behavior
iframe downsized also when using chromium browser.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Smartphone (please complete the following information):
n/a
Additional context
Add any other context about the problem here.
Any help greatly appreciated!
The text was updated successfully, but these errors were encountered: