Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with two 50 % slides when containScroll = true #30

Closed
gerhard-lechner opened this issue Oct 21, 2019 · 3 comments
Closed

Bug with two 50 % slides when containScroll = true #30

gerhard-lechner opened this issue Oct 21, 2019 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers resolved This issue is resolved

Comments

@gerhard-lechner
Copy link

Hi!

First of all, let me say that I really like embla-carousel. Thank you for sharing your awesome work!!

There's one little bug I discovered when I have two slides with width: 50% and containScroll is set to true. It doesn't appear if I have only one slide with width: 100% or three slides with width: 33.33%.

Here's a demonstration of what I'm talking about: https://codesandbox.io/s/embla-carousel-loop-true-xgg95

It's actually easy to fix by setting the width to 49.99 % but as this is only a workaround, I wanted to report the issue.

Once again, thanks for your efforts!

@davidjerleke davidjerleke added the bug Something isn't working label Oct 21, 2019
@davidjerleke
Copy link
Owner

davidjerleke commented Oct 21, 2019

Hi Gerhard (@niubsta),
Thank you very much! I'm happy to hear that you like Embla Carousel 🎉.

Nice catch! Thanks for taking time to report this and for the helpful demonstration. I will look into this as soon as possible and I'll let you know how it goes when I have an update.

Best,
David

@davidjerleke
Copy link
Owner

davidjerleke commented Oct 22, 2019

Hello Gerhard (@niubsta),

I've released a bug fix with version 2.5.3. I'd very much appreciate if you could bump to the latest version like so:

yarn add embla-carousel@latest

or:

npm install embla-carousel@latest

...and confirm if this fix works.

Thank you in advance!
David

@davidjerleke davidjerleke added the awaiting response Issue is awaiting feedback label Oct 22, 2019
@gerhard-lechner
Copy link
Author

Hello @davidcetinkaya ,

wow, that was quick - thank you so much!! I can confirm that the issue was solved by your fix!

Thanks again and kind regards,
Gerhard

@davidjerleke davidjerleke removed the awaiting response Issue is awaiting feedback label Oct 22, 2019
@davidjerleke davidjerleke added the good first issue Good for newcomers label Nov 1, 2019
@davidjerleke davidjerleke added the resolved This issue is resolved label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers resolved This issue is resolved
Projects
None yet
Development

No branches or pull requests

2 participants