Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal in Sass 4.0" with lib-sass 3.5.0 #37

Closed
jrencz opened this issue Mar 29, 2018 · 8 comments

Comments

@jrencz
Copy link

jrencz commented Mar 29, 2018

Since sass/node-sass now uses lib-sass 3.5.0 (since sass/node-sass@fe572eb, release 4.8.0) and lib-sass warns if a string is passed to call() sassdash started yielding A LOT of deprecation warnings like this one:

DEPRECATION WARNING: Passing a string to call() is deprecated and will be illegal
in Sass 4.0. Use call(get-function("--kebab-case-compounder")) instead.

It will probably take a while until sass 4.0 is released, but I predict a lot of people will look for the source of those errors.

There's already a bunch of reports about this kind of warning:

mmistakes/minimal-mistakes#1114
mtlynch/mtlynch.io#76
mmistakes/jekyll-theme-basically-basic#21

(those are from rubyland, where this warning surfaced earlier)

@lehni
Copy link

lehni commented Apr 12, 2018

I think this is the same issue as #29. I'd love to see this addressed, as node-sass 4.8.3 is flooding my terminal with endless warnings now...

@davidkpiano is there a plan to address this issue?

@davidkpiano
Copy link
Owner

@lehni I don't have time at the moment but feel free to create a PR, and I will review it, merge it, and release it promptly.

@lehni
Copy link

lehni commented Apr 12, 2018

@davidkpiano I've looked into it, but it's over my head ATM. I didn't even manage to get the tests to run, with the standard dependencies... I am getting this error:

Error: Invalid CSS after "...d: (('b', 'c'):": expected ")", was "'test2');"

@Nr9
Copy link
Contributor

Nr9 commented Apr 12, 2018

I completed the pull request

@davidkpiano
Copy link
Owner

Fixed in #38

@davidkpiano
Copy link
Owner

And released in 0.9.0 🎉

@lehni
Copy link

lehni commented Apr 12, 2018

Wow, amazing! Thank you @Nr9 and @davidkpiano for releasing so quickly!

Looking at the fix, I am wondering if a call_function($str) helper that calls call(get_function($str)) would be of use?

@lehni
Copy link

lehni commented Apr 12, 2018

@davidkpiano would you mind releasing a new version of https://github.com/davidkpiano/sass-svg also that uses 0.9.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants