Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use validation on effect Parameters sets #38

Open
davidlang42 opened this issue Aug 31, 2023 · 0 comments
Open

Use validation on effect Parameters sets #38

davidlang42 opened this issue Aug 31, 2023 · 0 comments

Comments

@davidlang42
Copy link
Owner

Within roland::types::effects there are a lot of types which need Validation. These should be validated in all Mfx, Reverb and Chorus Parameters sets, however the only way to do that at the moment is put #[validate] in front of every single field which will:

  • take a long time
  • make everything hard to read
  • likely to miss one anyway

A better option is an option which forces all sub-types to have Validation, so either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant