Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: app version + standalone as only arguments of example app script #758

Closed
davidlj95 opened this issue Aug 10, 2024 Discussed in #607 · 2 comments · Fixed by #759
Closed

build: app version + standalone as only arguments of example app script #758

davidlj95 opened this issue Aug 10, 2024 Discussed in #607 · 2 comments · Fixed by #759
Labels
dx enhancement New feature or request released

Comments

@davidlj95
Copy link
Owner

Discussed in #607

Originally posted by davidlj95 May 24, 2024
Currently to create an example app you call the script with the Angular version you want the example app created with. Noice, but that argument is linked to a hardcoded list of example apps.

This could be dynamic. The only thing impeding that rn is the standalone / non standalone argument. Which is what example apps hardcoded list is defined. If adding that as a CLI argument too:

  • No need to maintain a hardcoded list of example app configurations. The list of Angular CLI versions in the JSON file would be enough. Hence supporting a new Angular version is easier: a thing less to change
  • Standalone / non standalone can be created as wish. So we could create v16 with standalone an non-standalone for instance. Currently it's non standalone only as it's that version's CLI default.
@davidlj95 davidlj95 added enhancement New feature or request dx labels Aug 10, 2024
@davidlj95
Copy link
Owner Author

Eventually opted to go for just creating the Angular app as the Angular CLI does. Knowing that for v17 onwards will be standalone and otherwise module-based. This way no need to specify an extra param when calling the script + the verification if that Angular CLI version can create standalone apps. Indeed --standalone for new apps was introduced in v16. It's actually only Angular CLI v16 the major version that allows can create standalone apps but it's disabled by default

Copy link

🎉 This issue has been resolved in version 1.0.0-beta.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant