feat: ask whether to add routing in ng-add schematic
#975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #975 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 86 86
Lines 365 372 +7
Branches 52 54 +2
=========================================
+ Hits 365 372 +7 ☔ View full report in Codecov by Sentry. |
📦 Bundle size (Angular v16)Git ref:
|
davidlj95
deleted the
stacked/feat-ask-whether-to-add-routing-in-ng-add-schematic
branch
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
|
🎉 This PR is included in version 1.0.0-beta.27 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue or need
ng-addschematic added in #962 just adds the core provider.It could be nice for users to add routing and many metadata modules too.
Proposed changes
Add an option to the
ng-addschematic to enable the routing module.It can be enabled by
ng add @davidlj95/ngx-meta --routing. Defaults to not enabled.It's disabled by default and doesn't ask the user via
x-promptin the schema yet.This way, we can start asking for both routing & metadata modules all at once. At that moment, docs may be updated to reflect this new feature.
Quick reminders