-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: split between utility types and metadata values types #992
docs: split between utility types and metadata values types #992
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @davidlj95 and the rest of your teammates on |
📦 Bundle size (Angular v15)Git ref:
|
📦 Bundle size (Angular v18)Git ref:
|
📦 Bundle size (Angular v16)Git ref:
|
📦 Bundle size (Angular v17)Git ref:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #992 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 89 89
Lines 395 395
Branches 55 55
=========================================
Hits 395 395 ☔ View full report in Codecov by Sentry. |
🎉 This PR is included in version 1.0.0-beta.32 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Issue or need
In built-in modules docs, the only type reference is to the type helping to set metadata values JSON. However, there's another interesting type to see all the metadata a provider can set. Which is the same without the
Metadata
suffix. Reaching this one requires clicking in theMetadata
one and then clicking into the type. Which can be confusing as insdide theXMetadata
type there is thex
property and theX
type. So easy to click the not useful one.Proposed changes
Add reference to both types. Specify which one is the utility one and which one allows to see all metadata values that can be set for a provider.
Replace
module / providers
with justproviders
as providers API is recommended.Quick reminders