You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One of the things that threw me for a loop while giving the redact feature a spin in pino was the fact that it's not documented whether or not the redaction paths are case sensitive.
It turns out that they are. That makes it extremely burdensome to construct a comprehensive list for redacting logs across a wide organization. Consider socialsecuritynumber and the variations possible:
The argument here might be "well this is a code quality issue that should be caught or prevented," and that would be well justified. But across large orgs with varying teams, varying levels of skill, oversight, and caring, asserting code quality isn't a reasonable assertion.
First and foremost, the documentation needs to be updated to reflect the current state - paths are case-sensitive.
I'd love to see some consideration given to allowing for the search to be case-insensitive.
The text was updated successfully, but these errors were encountered:
One of the things that threw me for a loop while giving the
redact
feature a spin inpino
was the fact that it's not documented whether or not the redaction paths are case sensitive.It turns out that they are. That makes it extremely burdensome to construct a comprehensive list for redacting logs across a wide organization. Consider
socialsecuritynumber
and the variations possible:The argument here might be "well this is a code quality issue that should be caught or prevented," and that would be well justified. But across large orgs with varying teams, varying levels of skill, oversight, and caring, asserting code quality isn't a reasonable assertion.
First and foremost, the documentation needs to be updated to reflect the current state -
paths
are case-sensitive.I'd love to see some consideration given to allowing for the search to be case-insensitive.
The text was updated successfully, but these errors were encountered: