Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The exclusive use of "constructorHandlers" for checking the type may not be optimal. #44

Open
fangyeqing123 opened this issue Jun 26, 2024 · 3 comments

Comments

@fangyeqing123
Copy link

Is it possible to handle Element and HTMLElement uniformly based on "instanceof" when handling all DOM elements, as currently handling them one by one based on their constructors is cumbersome? When there are HTMLElement elements in the input object, it can cause rfdc to freeze. It would be helpful if internal memory leak handling could be implemented, and if the depth of the object hierarchy is too deep, a warning could be given, with the option to only copy specified depths of objects.

@fangyeqing123
Copy link
Author

When "circles" is enabled, having DOM elements in the object can cause the process to freeze.

@fangyeqing123
Copy link
Author

The attributes of a DOM element cannot be copied as well.

@mcollina
Copy link
Collaborator

Thanks for reporting! Would you like to send a Pull Request to address this issue? Remember to add unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants