Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen readers cannot read output #38

Open
davidmerfield opened this issue Jan 29, 2016 · 5 comments
Open

Screen readers cannot read output #38

davidmerfield opened this issue Jan 29, 2016 · 5 comments
Assignees
Labels

Comments

@davidmerfield
Copy link
Owner

davidmerfield commented Jan 29, 2016

Screen readers stumble on something like <span>a</span>t, reading it as 'A T' instead of 'at'.

This makes the optical margin alignment and hanging punctuation output unusable for people using screen readers.

We should be able to solve this using:

<p aria-label="at"><span>a</span>t</p>
@davidmerfield
Copy link
Owner Author

Google translate also screws up

@davidmerfield
Copy link
Owner Author

I've now disabled the optical margin alignment feature by default. It breaks too many things.

@davidmerfield davidmerfield changed the title Accessibility Screen readers cannot read output Jan 8, 2020
@danielhaim1 danielhaim1 self-assigned this Jan 8, 2020
@danielhaim1
Copy link
Collaborator

I need to think this through and do some research, from both web accessibility and search optimization.

One solution that was discussed is the possibility of adding an aria-label to the parent element that's being converted -- but that's too risky (and may require a major version bump that will break some sites).

  • If user has set .post-typeset to a <div> element that already contains aria-label it may break things.
  • I suppose we can wrap the element with another span that contains the aria-label, but I also need to double check that this is the best approach.

I'll be investigating this in the coming days.

@AndrewKvalheim
Copy link

Would it work to just wrap the whole word instead?

<span class="pull-A">At</span> the beginning

@davidmerfield
Copy link
Owner Author

@AndrewKvalheim Brilliant! I can't think of a good reason that would not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants