Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monochrome with Random Luminosity Isn't Monochrome #79

Closed
jasonpepper opened this issue Jan 31, 2017 · 3 comments · Fixed by #89
Closed

Monochrome with Random Luminosity Isn't Monochrome #79

jasonpepper opened this issue Jan 31, 2017 · 3 comments · Fixed by #89
Labels

Comments

@jasonpepper
Copy link

When I call randomColors with monochrome hue and random luminosity, the resulting colors are not monochrome.

http://codepen.io/x9xjdzz9/pen/rjJyjJ

@jackwilsdon
Copy link
Contributor

It looks like this is due to this if statement. I don't see a reason why the two statements couldn't be swapped so that we check for monochrome first.

@davidmerfield
Copy link
Owner

@jackwilsdon you're quite right, thank you for catching that. Would be happy to merge a PR if you're interested in the credit, otherwise will do this later today.

@davidmerfield
Copy link
Owner

Thanks Jack!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants