Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly Remove Dependency to JSR305 #115

Open
in-fke opened this issue Oct 5, 2023 · 3 comments
Open

Possibly Remove Dependency to JSR305 #115

in-fke opened this issue Oct 5, 2023 · 3 comments

Comments

@in-fke
Copy link

in-fke commented Oct 5, 2023

I would be great if we could remove the dependency to this "dormant" (rather dead) JSR305.
Actually, we currently have trouble with two Artifacts both exposing the package "javax.annotation" and JSR305 is one of them.

$ grep javax.annotation $(find . -name "*.java")
./src/main/java/org/subethamail/smtp/internal/server/ServerThread.java:import javax.annotation.concurrent.GuardedBy;
./src/main/java/org/subethamail/smtp/server/SMTPServer.java:import javax.annotation.concurrent.GuardedBy;
./src/main/java/org/subethamail/smtp/server/TimeBasedSessionIdFactory.java:import javax.annotation.concurrent.GuardedBy;
./src/main/java/org/subethamail/smtp/server/TimeBasedSessionIdFactory.java:import javax.annotation.concurrent.ThreadSafe;

Reference: https://stackoverflow.com/a/67415527/1747140

@in-fke
Copy link
Author

in-fke commented Oct 5, 2023

I forked the repo and did the changes there, in case you want to "copy" that.
in-fke#1

@davidmoten
Copy link
Owner

What is the other artifact? Can you just exclude the transitive dependency from subethasmtp in your pom (maven/gradle)?

@davidmoten
Copy link
Owner

davidmoten commented Oct 7, 2023

I'm happy to exclude the artifact. Can you make a PR? Please leave comments where you remove the annotations (like // ThreadSafe, // GuardedBy this). Do not remove the parent pom block, that is used for deployment to Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants