Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with guest login #16

Open
garemoko opened this issue Dec 2, 2013 · 4 comments
Open

Does not work with guest login #16

garemoko opened this issue Dec 2, 2013 · 4 comments

Comments

@garemoko
Copy link
Collaborator

garemoko commented Dec 2, 2013

Needs to fail gracefully.

@garemoko
Copy link
Collaborator Author

Guests should be allowed to enter a name and email address and then proceed.

@deaddecoy
Copy link

Hi,
Just started using the tincan launcher and ran into this issue. I'm going to hack a solution but would appreciate if this feature was built in. If I code something usable, I'll post it here.

@garemoko
Copy link
Collaborator Author

garemoko commented Jul 3, 2018

Thanks! The solutions I had in mind would be that either:

  1. Detect guest and use an anonymous actor.
  2. Detect guest and present an additional screen asking for their name and email.

@deaddecoy
Copy link

Hi,
Added functionality for guests.

  • view.php
    -- Put some PHP code in functions for readability.
    -- If guest, display field to collect guest email and launch new instance
    -- Else run user code
  • launch.php
    -- Added guest_id guest_email to $USER (avoided overwriting moodle $USER values)
  • lib.php
    -- tincanlaunch_getactor, Set values for Agent object
    -- if guest: set alt email, set name to random id (UUID), account set to default for CFG and user
    -- else try and get regular user

Setting the actor name as a uuid seemed ideal, as it would limit fetching someone else's data.

modified tincan launcher files.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants