Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is frontload compatible with renderToNodeStream? #58

Open
bjufre opened this issue Aug 23, 2021 · 4 comments
Open

Is frontload compatible with renderToNodeStream? #58

bjufre opened this issue Aug 23, 2021 · 4 comments

Comments

@bjufre
Copy link

bjufre commented Aug 23, 2021

Hello!

First of all thank you for this amazing library. We've been using it for a while, since the beginning of the project two-three years ago. Right now we're in the midst of trying to improve the SSR experience and we were trying to move from the renderToString to the renderToNodeStream. While the first one works as expected and seems to load all the data and send the HTML correctly down, it seems that the second is not "fetching"/calling the frontload in our components.

Any ideas as to why that might be or what can we do to solve the issue? Or is it a limitation of the library?


For a little bit of context, we're using:

  • v1 of Frontload
  • We rely heavily on class components still, redux, thunk, etc.
@bjufre
Copy link
Author

bjufre commented Sep 1, 2021

@davnicwil just making sure that this issue isn't getting buried 💪

@tmhao2005
Copy link

it seems like hook isn't called with when calling renderToNodeStream. I've also run into the same issue. Looks like it won't work for the stream case

@igorshmukler
Copy link

I would also be interested to see an example of react-frontload used in conjunction with renderToNodeStream.

@luischoma
Copy link

bumping +1;
i'm trying to upgrade from react 17 to 18 and then use renderToPipeableStream;

would very much appreciate a discussion on this; i'm willing to contribute if we ever come to a conclusion;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants