Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let caller pass in extra options to docker create #71

Open
sebastiankuzminsky opened this issue Nov 15, 2022 · 1 comment
Open

Let caller pass in extra options to docker create #71

sebastiankuzminsky opened this issue Nov 15, 2022 · 1 comment

Comments

@sebastiankuzminsky
Copy link

The "normal" way to run Github Actions in docker is to use jobs.<job_id>.container. This lets the user pass extra args to docker create using jobs.<job_id>.container.options. We in the LinuxCNC project use this to enable some extra capabilities we need for testing inside the container: https://github.com/LinuxCNC/linuxcnc/blob/master/.github/workflows/ci.yml#L66-L75.

But the Github ubuntu-* runners do not have qemu-user-static installed, so you can only run docker containers of the native CPU architecture.

I really want to use action-debian-package because it installs qemu-user-static, so it supports building on different CPU architectures. But it doesn't support options, so our test suite can't run.

This issue is a feature request: please add a way for the user to specify extra options to docker create.

@dawidd6
Copy link
Owner

dawidd6 commented Jan 6, 2024

Will accept a PR adding this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants