Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪 Remove ethers/web3 from most test functions + mock network #201

Closed
dawsbot opened this issue Mar 14, 2023 · 1 comment
Closed

🧪 Remove ethers/web3 from most test functions + mock network #201

dawsbot opened this issue Mar 14, 2023 · 1 comment

Comments

@dawsbot
Copy link
Owner

dawsbot commented Mar 14, 2023

The tests should not have a runtime dependency on ethersjs nor web3.js. In-addition, we have a lot of network needs currently which are flaky:

  1. Remove ethers from all test files
  2. Remove web3 from all test files
  3. Mock all network requests to return with the appropriate data an eth node would
  4. Spy on the network request to ensure the incoming request is accurate.

You can see an example of ALL of this here

@dawsbot dawsbot changed the title Remove ethers from most test functions Remove ethers and web3 from most test functions Mar 14, 2023
@dawsbot dawsbot changed the title Remove ethers and web3 from most test functions Remove ethers/web3 from most test functions + mock network Apr 21, 2023
@dawsbot dawsbot changed the title Remove ethers/web3 from most test functions + mock network 🧪 Remove ethers/web3 from most test functions + mock network Apr 23, 2023
@dawsbot
Copy link
Owner Author

dawsbot commented Jun 6, 2023

Completed last month thanks to @jtfirek 🙏

@dawsbot dawsbot closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant