- The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes.
- The PR explanation includes the words "Fixes #bugnum: ...".
- The linter/Karma presubmit checks have passed.
- These should run automatically, but if not, you can manually trigger them locally using
python scripts/pre_commit_linter.py
andbash scripts/run_frontend_tests.sh
.
- These should run automatically, but if not, you can manually trigger them locally using
- The PR is made from a branch that's not called "develop".
- The PR follows the style guide.
- The PR is assigned to an appropriate reviewer.
- If you're a new contributor, please ask on Gitter for someone to assign a reviewer.
- If you're not sure who the appropriate reviewer is, please assign to the issue's "owner" -- see the "talk-to" label on the issue.