Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flexible configuration of complex components #123

Open
p-himik opened this issue Nov 24, 2016 · 0 comments
Open

Flexible configuration of complex components #123

p-himik opened this issue Nov 24, 2016 · 0 comments
Assignees
Labels

Comments

@p-himik
Copy link
Contributor

p-himik commented Nov 24, 2016

I really like how input-text has status icon functionality, so you don't need to write it yourself.
The only problem with it is configuration. I've added a couple of arguments to input-text-args-desc to alter icon size and tooltip position, and the args list already looks overburdened. Also, I wanted to change particular icons and tooltip color. Since it feels like it's more related to a global theme, I added a couple of atoms with default values for re-com theme that I swap! with particular changes for my theme.

All this made me thinking that it would be nice to have a common way to configure complex components. Some have hard-coded colors or other style elements, many have hard-coded classes for Material Design icons. I think that it'd be great to either extract such things into atoms that can be set to other values in other people's application or to use Less instead of CSS to parameterize different style elements.

If you agree, I think this work can be done gradually and I'd be happy to create new PR for components that I use and want to customize as soon as I start customizing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants