Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't hardcode colors #33

Open
Frozenlock opened this issue Jun 25, 2015 · 0 comments
Open

Don't hardcode colors #33

Frozenlock opened this issue Jun 25, 2015 · 0 comments

Comments

@Frozenlock
Copy link
Contributor

For example: https://github.com/Day8/re-com/blob/master/src/re_com/modal_panel.cljs#L49 and https://github.com/Day8/re-com/blob/master/src/re_com/splits.cljs#L120

The components aren't compatible with bootstrap dark themes because of this.
IMO colors shouldn't be hardcoded. A possible middle ground could be to use classes.
(Re-com already needs its own CSS anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants