Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gitbook Builds? #580

Closed
mike-thompson-day8 opened this issue Apr 9, 2020 · 3 comments
Closed

Remove Gitbook Builds? #580

mike-thompson-day8 opened this issue Apr 9, 2020 · 3 comments
Assignees

Comments

@mike-thompson-day8
Copy link
Contributor

mike-thompson-day8 commented Apr 9, 2020

Remove the Gitbook generation parts of the repo and decommission the associated build process.

Why?

First, the Gitbook generation is unused, I think. There are no public-facing links to it anywhere, as far as I’m aware. For the record, here is the link

Second, I'm getting emails from GitBook telling me to update the integration because the existing integration is now legacy and will stop working soon.

Third, I’m not confident it is working 100% correctly any more (although it might be)? Eg. I just found that /docs/INTRO.md seems to hold a copy of /README.md ... except it hasn't been kept up to date with the small adjustments made to /README.md over time, and discovering that is probably the last straw that drove me to make this issue.

Fourth, the contributor who wanted to see GitBook used is no longer around and even when they were around they only progressed this project part the way (as I understand it).

Doing The Removal

Notes on removing:

  • See this PR for the original details
  • And these aliases
  • There will be some webhook somewhere to trigger the build process

And Then?

Perhaps we can then regroup on docs and figure out a new way forward for creating a nice looking set of docs from the underlying .md files we have in /docs. (I don't think that Gitbook ever looked very good anyway … although obviously it was a little better than the current straight GitHub .md files)

@include
Copy link

include commented May 5, 2020

@superstructor
Copy link
Contributor

superstructor commented May 6, 2020

  • Remove Installed GitHub app which does GitBook integration
  • Remove the Gitbook entry for re-frame
  • Remove code from the re-frame repo (i.e project.clj aliases)

@superstructor superstructor self-assigned this May 6, 2020
@mike-thompson-day8
Copy link
Contributor Author

@include discussion is now at #582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants