-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation problems #2
Comments
Atm I expect the release 'tag names' to be of the form v0.0 for major releases and v0.0.0 for minor releases. The difference between those kind of releases in AnkiHub: Major releases shall always contain the entire plugin and minor releases can be partial updates (e.g. if you change only one .py file). So e.g. when the user has v1.0 installed and the newest release is v1.0.6, then the system will download all files for the releases from v1.0.1 to v1.0.6. But if the newest release is v1.1 it will only update this full release. So when you decide to always upload the entire plugin, please use only tag names of the form v0.0 According to that error message, if this is for Stvad/CrowdAnki then your tag names are ill formed: So just rename 0.3.1 to v0.3.1. This format is even suggested by github how to name the tags, but I admit that I should mention it in the usage instructions :P |
Yeah, this should be definitely mentioned in user manual :). I still have some questions: |
Also error messages on this kind of problems would be nice :) |
Yes, it will! Though you should rather make a major release out of that, so the user doesn't have to download 10 "full" minor versions if he didn't update for a while. For most plugins this different treatment of major and minor releases might not be necessary, but at least my very specific usecase dayjaby/yomisama is about 50MB big and it's extremely annoying to upload this completely every time.
Yes, you can. Just have a zip file with the proper directory hierarchy. E.g. if you want to update addons/MyPlugin/MySubDir/myScript.py, then you can create the correct zip file by being in addons/ and running
Be aware, that this 7z a appends to a zip file. Make sure you delete the zip file before or you'll end up with ankihub.py and ___ankihub.py as well ^^ |
I've renamed the tag, but it still not working for me :(. Now I'm getting:
|
I see. I understand the use case for minor versions :) |
I thought about the very same ^^ Maybe some kind of script that runs together with each git commit? Should be rather easy to solve.
I had a similar issue today where https://api.github.com/repos/dayjaby/AnkiHub/releases/latest didn't give me the "latest" release. Similarily https://github.com/Stvad/CrowdAnki/releases/tag/v0.3 shows the proper major release, but https://api.github.com/repos/Stvad/CrowdAnki/releases/tags/v0.3 shows an error...should report those bugs to github I think. |
It need not be each commit, as you can get "files changed since tag x" via git. Would be really useful. I'm not sure it's an error, I think link like https://api.github.com/repos/Stvad/CrowdAnki/releases/tags/vxxx will show you something, only if there is an actual "Github release" associated with that tag. If it's just tag it will return an error. |
Yes, you are right. On https://github.com/Stvad/CrowdAnki/tags you should see a button "Add release notes" next to the tag v0.3. After adding those relesease notes, it should work! So as a guideline: If you have a version v0.3.2 then v0.3, v0.3.1 and v0.3.2 must be proper "releases" in github. |
Ah, so it finally worked :). It would be nice to have a progress bar, while plugin is doing it's stuff on install. |
Btw, You should add readme to the repo with the manual ;) |
Updating my plugin seems to have worked well.
But I have a problem with installing it from scratch. As I've mentioned in #1 - I have 2 buttons "from Github". So I tried both of them 😄.
With the first one - I'm getting the following error:
With the second one - nothing happens after I press ok on the dialog window.
Windows, Anki 2.0.36.
Maybe important - the extension was installed before, then I've deleted it and trying to install it via AnkiHub.
The text was updated successfully, but these errors were encountered: