Skip to content

Commit ed3e741

Browse files
committed
chore(chips): remove html lint ignores, add label for single-chip entry in patternlab
1 parent fa15a5b commit ed3e741

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

Diff for: source/_patterns/01-elements/chips/_chip.hbs

-4
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,25 @@
11
{{! TODO: This would need to get enhanced later on by the additional possible attributes }}
22
{{#if selection}}
3-
<!-- [html-validate-disable-next input-missing-label -- label get read out on the input field already and could get aria hidden] -->
43
<input
54
class="elm-chip"
65
type="radio"
76
id="chip-single-{{ variant }}{{ id-suffix }}"
87
name="{{ name }}"
98
data-type="selection"
109
{{#if disabled }} disabled{{/if }}>
11-
<!-- [html-validate-disable-next prefer-native-element -- TODO: Evaluate again on this HTML] -->
1210
<label
1311
for="chip-single-{{ variant }}{{ id-suffix }}"
1412
{{#if variant }} data-variant="{{ variant }}"{{/if }}
1513
{{#if icon }} data-icon="{{ icon }}"{{/if }}
1614
{{#if iconAfter }} data-icon-after="{{ iconAfter }}"{{/if }}
1715
>{{ label }}</label>
1816
{{else}}
19-
<!-- [html-validate-disable-next input-missing-label -- label get read out on the input field already and could get aria hidden] -->
2017
<input
2118
class="elm-chip"
2219
type="checkbox"
2320
id="chip-multiple{{#if disabled }}-disabled{{/if}}-{{ variant }}{{ id-suffix }}"
2421
data-type="filter"
2522
{{#if disabled }} disabled{{/if }}>
26-
<!-- [html-validate-disable-next prefer-native-element -- TODO: Evaluate again on this HTML] -->
2723
<label
2824
for="chip-multiple{{#if disabled }}-disabled{{/if}}-{{ variant }}{{ id-suffix }}"
2925
{{#if variant }} data-variant="{{ variant }}"{{/if }}

Diff for: source/_patterns/01-elements/chips/_chip.json

+3
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
{
2+
"label": "Title"
3+
}

0 commit comments

Comments
 (0)