Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored attributes left blank #4

Open
vwwv opened this issue Mar 23, 2018 · 1 comment
Open

Ignored attributes left blank #4

vwwv opened this issue Mar 23, 2018 · 1 comment

Comments

@vwwv
Copy link

vwwv commented Mar 23, 2018

Hi!
Awesome library! It almost works out of the box, though there are some small issues that make it rely on human attention.

One of it is:

Not recognised attributes are left blank, for example this:

<div  class="a" somethingStrange="x"> ...

gets into this:

div_ [class_ "a" , ] ...

Notice the extra , yielding a syntax error when compiling.
It should be:

div_ [class_ "a" , makeAttribute "somethingStrange" "x"] ... 
@dbaynard
Copy link
Owner

dbaynard commented Mar 24, 2018

@alogic0 has done significant work and you should try https://github.com/alogic0/lucid-from-html instead of this. It may already have a fix for your problem, and is being actively maintained (ditto for #5).

Edit: And thanks! Though I can only take a small amount of credit, as I adapted the library. I rewrote bits of the code printer to output lucid instead of blaze code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants