Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate check_api and ensure_orbit_credentials #665

Open
garlic-os opened this issue Jul 8, 2024 · 0 comments
Open

Consolidate check_api and ensure_orbit_credentials #665

garlic-os opened this issue Jul 8, 2024 · 0 comments
Labels
cleanup

Comments

@garlic-os
Copy link
Contributor

RAiDER.models.credentials.check_api and RAiDER.s1_orbits.ensure_orbit_credentials have duplicated functionality. For the sake of keeping the code easy to understand and to test, I would suggest that we come up with a solution where what they do is either separated completely or joined into one function.
@garlic-os garlic-os added the bug Something isn't working label Jul 8, 2024
@jlmaurer jlmaurer added cleanup and removed bug Something isn't working labels Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@garlic-os @jlmaurer