Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get look direction parameter ready for NISAR #676

Open
garlic-os opened this issue Jul 22, 2024 · 2 comments
Open

Get look direction parameter ready for NISAR #676

garlic-os opened this issue Jul 22, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@garlic-os
Copy link
Contributor

The look_dir parameter as provided in a YAML file is never used. It is accessed in one spot to validate that it is either "left" or "right", and never again. A vscode all files search for the term "look_dir" only produces results from inside other data structures and that one validation check, and none where the look_dir from a YAML run config gets used.

Do we not use Look Direction anymore, or is it being left out somewhere on accident?

Desktop

  • RAiDER git tag:
    commit 2a34802 (HEAD -> dev, tag: v0.5.2, upstream/main, upstream/dev, upstream/HEAD)
    Merge: 223d862 2b7190c
    Author: Jeremy Maurer maurer.jeremy@gmail.com
    Date: Mon Jul 15 11:54:29 2024 -0500
        Merge pull request v0.5.2 #670 from dbekaert/dev
        v0.5.2
  • OS: Arch Linux 5.15.153.1-microsoft-standard-WSL2 on Windows 10
@garlic-os garlic-os added the bug Something isn't working label Jul 22, 2024
@dbekaert
Copy link
Owner

Not all sensors have same look direction. Will defer to @jlmaurer if this was a placeholder for the future. E.g. NISAR/ CSK etc.

@jlmaurer jlmaurer added cleanup enhancement New feature or request and removed bug Something isn't working cleanup labels Jul 24, 2024
@jlmaurer
Copy link
Collaborator

@dbekaert @garlic-os yes this will depend on the sensor. Right now everything is right-looking, but very soon we will have a left-looking sensor (NISAR). We may want to take a look at the workflow and make sure the look direction is properly carried through.

@jlmaurer jlmaurer changed the title Main delay calculation workflow: Look Direction is unused Get look direction parameter ready for NISAR Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants