Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support double & double_complex #13

Open
chengbinfeng opened this issue Sep 7, 2021 · 1 comment
Open

Support double & double_complex #13

chengbinfeng opened this issue Sep 7, 2021 · 1 comment

Comments

@chengbinfeng
Copy link

These data types are much more useful in the science caculation. I would like to modify the data type but worry the algorithm cannot support that.

@dblalock
Copy link
Owner

dblalock commented Sep 8, 2021

Hi chengbinfeng ,

Sounds great. Since the operations are approximate anyway, this should just be a matter of writing a wrapper that turns float64 into float32 (ideally fused with the C++ encoding functions, but it shouldn't make much difference unless the matrices are extremely skinny).

EDIT: actually, complex will be much harder...we'd need to rewrite the low-level encoding functions to operate on complex numbers here, as well as define what if even means to cluster or split on complex values in this context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants