Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"score" parameter in Data.add_detection is annotated as "int", should probably be "float" #37

Open
drewm1980 opened this issue Nov 25, 2021 · 0 comments

Comments

@drewm1980
Copy link

drewm1980 commented Nov 25, 2021

mypy did not complain because it considers int a subtype of float, for better or worse:
https://mypy.readthedocs.io/en/stable/duck_type_compatibility.html

but it bites your callers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant