Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Athena dbt-external-tables impl as independent package #633

Closed
1 task done
brabster opened this issue Apr 27, 2024 · 6 comments
Closed
1 task done

[Feature] Athena dbt-external-tables impl as independent package #633

brabster opened this issue Apr 27, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@brabster
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have searched the existing issues, and I could not find an existing issue for this feature

Describe the feature

We've been waiting for literally years to get an Athena implementation of dbt-external-tables merged. This working repo demonstrates an independent implementation for athena, using dbt-external-tables as an interface and generic impl

https://github.com/brabster/dbt-athena-external-tables

Describe alternatives you've considered

Merge into dbt-external-tables. Not happened for a long time, if it did happen and any changes needed to be made, it could be problematic getting a response. This solution decouples the Athena implementation without any copy-paste maintenance.

2nd PR to dbt-external-tables, raised May 2023 dbt-labs/dbt-external-tables#203. (All due credit to original PR dbt-labs/dbt-external-tables#133 raised Feb 2022)

Who will this benefit?

All Athena users wishing to use external tables. dbt-athena-community maintainers who will need to maintain this functionality and would not choose to be tightly coupled to the dbt-external-tables maintainers

Are you interested in contributing this feature?

I have contributed a working solution. I am not interested in being a maintainer.

Anything else?

No response

@nicor88
Copy link
Contributor

nicor88 commented May 8, 2024

Happy to be a maintainer of dbt-external-tables for athena for the time being. @jessedobbelaere seems fine with it too. @Jrmyy @svdimchenko wdyt?

@brabster
Copy link
Contributor Author

brabster commented May 8, 2024

I can't transfer, no access. Keen to move asap to avoid breaking/confusing people when it does happen.

Would one of you like to just create a new repo and init with the contents of this instead? I can put a banner on this deprecating and pointing over to the official one?

image

@nicor88
Copy link
Contributor

nicor88 commented May 9, 2024

@brabster to transfer ownership we need to grant you permissions, see here. If you don't mind I will reach out in dbt slack to coordinate this :)

@Jrmyy
Copy link
Contributor

Jrmyy commented May 20, 2024

Hello,

I don't mind supporting also this repository. We did it for athena-utils, it makes sense :)

@nicor88
Copy link
Contributor

nicor88 commented May 21, 2024

Thanks @Jrmyy , we can follow up with @brabster to transfer ownership. 3 out of 5 maintainers are in favor.

@nicor88
Copy link
Contributor

nicor88 commented Jun 17, 2024

@nicor88 nicor88 closed this as completed Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants