Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic recording #140

Closed
1 task done
emmyoop opened this issue May 28, 2024 · 0 comments · Fixed by #135
Closed
1 task done

Add dynamic recording #140

emmyoop opened this issue May 28, 2024 · 0 comments · Fixed by #135

Comments

@emmyoop
Copy link
Member

emmyoop commented May 28, 2024

Housekeeping

  • I am a maintainer of dbt-common

Short description

We capture too much data with every run. Add the ability to dynamically capture different data.

Acceptance criteria

  • we can capture data by record type

Suggested Tests

test the different possible record types

Impact to Other Teams

adapters if any changes are required for them

Will backports be required?

no

Context

Instead of capturing everything for every run, we should be able to specify what data we want to capture.

Exactly what options we want to offer will be part of this ticket. It should start with the minimal requirements (the data we will need to compare the SQL from one run with another run via the diff functionality

Add DBT_RECORD=True to your dbt command (ie. DBT_RECORD=True dbt run). This generates a recording.json in the current working dir.

Options

This can be specified in the RecorderMode.

Use an env var in addition to DBT_RECORD/DBT_REPLAY to specify what we want to record

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant