[Bug] saved queries are always selected as "modified", they should not be

[graciegoheen]

Is this a new bug in dbt-core?

• I believe this is a new bug in dbt-core
• I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

Saved queries are always selected as "modified"

Expected Behavior

Saved queries should only be selected as "modified" when they have been modified

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

No response

[graciegoheen]

Potentially related to -> #9548

[tlento]

A community member is reporting the exact opposite behavior - saved queries do not show up in state:modified or state:new even when they should. Here's the repro step sequence they provided in the linked Slack thread:

Steps used for testing:

1. Upgrade existing projects to dbt v1.8
2. Run dbt parse for project containing semantic models
3. Rename target to old-target
4. Edit semantic model (edit existing saved query, add new saved query)
5. Make edits to SQL model as a control for the test
6. Run dbt parse again
7. Run dbt ls -s "state:modified state:new" --target old-target

Result: no semantic model changes detected, SQL model change detected as expected. 

[tlento]

Per latest update, it's possible saved queries are no longer picked up by state selectors at all, as running the dbt ls with a selector for state:old also returns no saved queries.

[gshank]

I wasn't able to recreate the "always selected as modified" either. I'll take a look at "never selected as modified" now.

[graciegoheen]

@dbeatty10 was also not able to reproduce the "always selected as modified" - let me know if you're able to reproduce the opposite!

[gshank]

It looks like saved_queries have never been included in the "modified" selector.

[graciegoheen]

We are not able to reproduce this original bug, so I’m going to close it out for now. We can re-open if we get more reports of this bug.

I will open a separate issue for the situation you're describing @tlento