Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer existing project nodes to external nodes, even if the project node is disabled #10224

Closed
1 task done
MichelleArk opened this issue May 24, 2024 · 0 comments · Fixed by #10223
Closed
1 task done
Assignees

Comments

@MichelleArk
Copy link
Contributor

MichelleArk commented May 24, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

Currently, an external node can clobber an existing project node if that project node is disabled. This should not be the case as it leads to duplicative nodes in the manifest! (one in manifest.nodes, one in manifest.disabled)

Acceptance criteria

When injecting an external node to the manifest that already exists from the FS, handle merges by:

  1. Enabled project nodes are preferred to external nodes
  2. Disabled project nodes are preferred to external nodes

Suggested Tests

tests follow from A/C :)

Impact to Other Teams

N/A

Will backports be required?

nope

Context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant