Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create "happy path" project fixture and use it for tests/functional/list/test_list.py #10256

Closed
1 task done
Tracked by #9649
QMalcolm opened this issue Jun 3, 2024 · 0 comments · Fixed by #10291
Closed
1 task done
Tracked by #9649
Assignees

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jun 3, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

When we write functional tests we generally end up writing more fixtures. A lot of these fixtures we write are either duplicates of fixtures for other functional tests that already exist (or are very close copies). Additionally because we don't have a standard "happy path" fixture, it has happened a few times that test which checks specific functionality fails to detect that it is broken when a certain type of node is involved because it wasn't included in the project fixture. By creating a happy path project fixture we solve both issues. Tests should try to use existing nodes in the happy path fixture, and when they cannot, add a new node to it (so all tests get it). Additionally because the happy path fixture will be broad, it should help guarantee node types existing don't break certain functionalities.

Acceptance criteria

  • There exists a happy_path_project fixture for our functional tests
  • We use it for tests in tests/functional/list/test_list.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants