Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create parameterized test which tries each resource type with the resource_type: selector #10287

Closed
1 task done
Tracked by #9649
QMalcolm opened this issue Jun 10, 2024 · 2 comments · Fixed by #10480
Closed
1 task done
Tracked by #9649
Assignees

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Jun 10, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

Sometimes we add a node and assume a fair amount of the dbt system functionality will come built in. In reality this isn't always the case. Sometimes we under assume, sometimes we over assume what comes by default. We want to build tests which automatically check all "inputs", even as that changes over time.

To that end, in this issue specifically, we want to test that all resource types that are supposed to be usable with the resource_type: selector don't break when used.

Acceptance criteria

  • A test exists which tests all acceptable resource types with the resource_type: selector
  • If a new resource_type is added, the parametrized test should automatically start testing it

Context

This would have helped catch issues like: #9532

@QMalcolm QMalcolm added Refinement Maintainer input needed and removed Refinement Maintainer input needed labels Jun 10, 2024
@QMalcolm
Copy link
Contributor Author

From refinement:

  • Maybe GraphNodes can be used
  • Maybe define an enum similar to how Retry works
  • Maybe add properties to nodes and add helpers to pull what node types should support specific functionality

@QMalcolm
Copy link
Contributor Author

QMalcolm commented Jun 17, 2024

Source nodes aren't selectable by the --select "resouce_type:<resource_type> syntax. Unsure whether this is intentional or not (documentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant