Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use protoc 5.26.1 to generate core_types_pb2.py #10457

Closed
1 task done
MichelleArk opened this issue Jul 17, 2024 · 0 comments · Fixed by #10456
Closed
1 task done

use protoc 5.26.1 to generate core_types_pb2.py #10457

MichelleArk opened this issue Jul 17, 2024 · 0 comments · Fixed by #10456
Assignees
@MichelleArk
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality tidy_first "Tidy First" incremental cleanup changes

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

Currently types_pb2.py is generated using protoc version 4.25.3. It looks like the latest compatible version of protoc that doesn't need any code changes (indicated by failing tests is 5.26.1).

Acceptance criteria

generate core_types_pb2.py with protoc version 5.26.1

Suggested Tests

n/a

Impact to Other Teams

n/a

Will backports be required?

nope

Context

No response
@MichelleArk MichelleArk added tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality tidy_first "Tidy First" incremental cleanup changes labels Jul 17, 2024
@MichelleArk MichelleArk self-assigned this Jul 17, 2024
@MichelleArk MichelleArk mentioned this issue Jul 17, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MichelleArk MichelleArk

Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality tidy_first "Tidy First" incremental cleanup changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[tidy first] generate protos w protoc version 5.26.1 dbt-labs/dbt-core
1 participant
@MichelleArk