Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and check source distributions and wheels independently in build packages #10465

Open
1 task done
MichelleArk opened this issue Jul 18, 2024 · 1 comment
Open
1 task done
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

  • dbt-core has overlaps in its build dependencies and functional ones (e.g. packages)
  • setuptools 71+ no longer vends its dependencies and will rely on dependencies installed in the system
  • this means the wheel install could change the python dependencies before source distribution install and validation
  • we've fixed this by swapping the order in 1.3 and below (since the packages conflict only arose there), but a better long term fix would be to build and check wheels and source dists in separate venvs to avoid package conflicts

Acceptance criteria

build and check wheels and source dists in separate venvs to avoid package conflicts in the build packages step of workflows/main.yml

Suggested Tests

n/a

Impact to Other Teams

n/a

Will backports be required?

yes, back to and including 1.4

Context

No response

@MichelleArk MichelleArk added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jul 18, 2024
@QMalcolm
Copy link
Contributor

Would this be a good opportunity to move away from setup.py to pyproject.toml and hatch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

2 participants