Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incremental tables with varchar columns get bumped to varchar 256 #10501

Open
gshank opened this issue Jul 29, 2024 · 0 comments
Open

Incremental tables with varchar columns get bumped to varchar 256 #10501

gshank opened this issue Jul 29, 2024 · 0 comments

Comments

@gshank
Copy link
Contributor

gshank commented Jul 29, 2024

Current Behavior

In #10362 we fixed a bug where incremental tables with varchar columns and a contract were getting the varchar columns increased to size 256, which didn't match the column. In the interests of getting it fixed for the most egregious case, we limited
the execution of expand_target_columns_types to non-contracted incremental tables, however there is still probably a problem for non-contracted tables getting varchar columns changed to 256 because of awkwardnesses in the way the code works with varchar column sizes.

Expected Behavior

Incremental table varchar columns are not bumped to 256 when it's not needed.

Steps to Reproduce

Relevant log output

Additional Context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant